Max Reitz <mre...@redhat.com> writes: > On 13.10.18 22:36, Eduardo Habkost wrote: >> On Sat, Oct 13, 2018 at 08:20:25PM +0200, Max Reitz wrote: >>> On 13.10.18 07:02, Eduardo Habkost wrote: >>>> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> >>>> --- >>>> I'd like to do this in QEMU 3.1. I think it's time to drop >>>> support for old systems that have only Python 2. >>>> >>>> We still have a few scripts that are not required for building >>>> QEMU that still work only with Python 2 (iotests being the most >>>> relevant set). Requiring Python 3 for building QEMU won't >>>> prevent people from using those scripts with Python 2 until they >>>> are finally ported. >>> >>> It very much does because the iotests specifically use the python path >>> qemu was configured with. >>> >>> To fix this, configure would need to write something else for into >>> tests/qemu-iotests/common.env for $PYTHON. But what? I don't really >>> want to introduce a new configure option for this. >> >> What's wrong with '/usr/bin/env python2' and just using the >> python2 binary from $PATH? Why do we need to make the Python >> interpreter path for iotests configurable? > > Nothing, sounds good. No idea why I discarded that idea. > >>> So the real fix is indeed to make the iotests work with Python 3, and I >>> think that needs to be done before we can require Python 3. Maybe it >>> even needs to be done at the same time. >> >> I agree that this would be even better. I just don't think the >> pending iotest porting should force all the rest of the build >> scripts to be compatible with Python 2. > > True. It just means that we have to do something about the iotests > before this patch can be merged.
I keep hearing about that "we" guy, and all the stuff he has to do, but I've never seen him deliver anything.
