On Fri, Nov 16, 2018 at 03:43:16PM -0600, Eric Blake wrote: > On 11/16/18 3:41 PM, Eric Blake wrote: > > > > +#!/bin/bash > > > > I know we're using bash, > > > > > + > > > +function nbd_server_stop() > > > +{ > > > > > +function nbd_server_wait_for_unix_socket() > > > > and bash supports 'function', but it is an obsolete syntactic sugar > > thing that I don't recommend using. (In ksh, it actually makes a > > difference in behavior whether you use 'function' or not, and using it > > in 'bash' makes it harder to port code over to 'ksh' - and hence in bash > > it is obsolete because here it does NOT cause the change in behavior > > that ksh users expect) > > > > Of course, I hit send too soon, before getting to my punchline: > > Since we already have so many existing iotests that use 'function', it's > better to clean that up as a separate patch.
Yeah, I actually thought 'function' was the preferred syntax and omitting it was bad since so many iotests used it :-) Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|