On Sat, Nov 17, 2018 at 02:49:22PM -0600, Eric Blake wrote: > On 11/16/18 9:53 AM, Daniel P. Berrangé wrote: > > Add tests that validate it is possible to connect to an NBD server > > running TLS mode. Also test mis-matched TLS vs non-TLS connections > > correctly fail. > > --- > > Missing your Signed-off-by. Can you please supply that, so I can include > this in my pull request?
Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > > Also, I'm getting failures when trying to test it: > > @@ -17,9 +17,9 @@ > > == check plain client to TLS server fails == > option negotiation failed: read failed: Unexpected end-of-file before all > bytes were read > +write failed (error message): Unable to write to socket: Broken pipe > qemu-img: Could not open 'nbd://localhost:10809': TLS negotiation required > before option 8 (structured reply) > server reported: Option 0x8 not permitted before TLS > -write failed (error message): Unable to write to socket: Broken pipe > > > which looks like an output race. :( Guess that shows the message is in fact coming from the server rather than the client then. We could just silence the qemu-nbd process to null, since we're primarily interested in what the client displays in this test Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
