> -----Original Message----- > From: Paul Durrant > Sent: 28 November 2018 16:46 > To: 'Kevin Wolf' <kw...@redhat.com> > Cc: 'Stefano Stabellini' <sstabell...@kernel.org>; qemu-block@nongnu.org; > qemu-de...@nongnu.org; xen-de...@lists.xenproject.org; Eduardo Habkost > <ehabk...@redhat.com>; Michael S. Tsirkin <m...@redhat.com>; Marcel > Apfelbaum <marcel.apfelb...@gmail.com>; Anthony Perard > <anthony.per...@citrix.com>; Paolo Bonzini <pbonz...@redhat.com>; Richard > Henderson <r...@twiddle.net> > Subject: RE: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and > 'XenDevice' object hierarchy > > > -----Original Message----- > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Sent: 28 November 2018 16:39 > > To: Paul Durrant <paul.durr...@citrix.com> > > Cc: 'Stefano Stabellini' <sstabell...@kernel.org>; qemu- > bl...@nongnu.org; > > qemu-de...@nongnu.org; xen-de...@lists.xenproject.org; Eduardo Habkost > > <ehabk...@redhat.com>; Michael S. Tsirkin <m...@redhat.com>; Marcel > > Apfelbaum <marcel.apfelb...@gmail.com>; Anthony Perard > > <anthony.per...@citrix.com>; Paolo Bonzini <pbonz...@redhat.com>; > Richard > > Henderson <r...@twiddle.net> > > Subject: Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and > > 'XenDevice' object hierarchy > > > > Am 28.11.2018 um 17:29 hat Paul Durrant geschrieben: > > > > -----Original Message----- > > > > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > > > > Sent: 28 November 2018 16:28 > > > > To: Paul Durrant <paul.durr...@citrix.com> > > > > Cc: 'Kevin Wolf' <kw...@redhat.com>; qemu-block@nongnu.org; qemu- > > > > de...@nongnu.org; xen-de...@lists.xenproject.org; Stefano Stabellini > > > > <sstabell...@kernel.org>; Eduardo Habkost <ehabk...@redhat.com>; > > Michael > > > > S. Tsirkin <m...@redhat.com>; Marcel Apfelbaum > > > > <marcel.apfelb...@gmail.com>; Anthony Perard > > <anthony.per...@citrix.com>; > > > > Paolo Bonzini <pbonz...@redhat.com>; Richard Henderson > > <r...@twiddle.net> > > > > Subject: RE: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' > > and > > > > 'XenDevice' object hierarchy > > > > > > > > On Wed, 28 Nov 2018, Paul Durrant wrote: > > > > > > -----Original Message----- > > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > > Sent: 28 November 2018 16:19 > > > > > > To: Paul Durrant <paul.durr...@citrix.com> > > > > > > Cc: qemu-block@nongnu.org; qemu-de...@nongnu.org; xen- > > > > > > de...@lists.xenproject.org; Stefano Stabellini > > > > <sstabell...@kernel.org>; > > > > > > Eduardo Habkost <ehabk...@redhat.com>; Michael S. Tsirkin > > > > > > <m...@redhat.com>; Marcel Apfelbaum <marcel.apfelb...@gmail.com>; > > > > Anthony > > > > > > Perard <anthony.per...@citrix.com>; Paolo Bonzini > > > > <pbonz...@redhat.com>; > > > > > > Richard Henderson <r...@twiddle.net> > > > > > > Subject: Re: [Qemu-block] [PATCH 02/18] xen: introduce new > > 'XenBus' > > > > and > > > > > > 'XenDevice' object hierarchy > > > > > > > > > > > > Am 21.11.2018 um 16:11 hat Paul Durrant geschrieben: > > > > > > > This patch adds the basic boilerplate for a 'XenBus' object > that > > > > will > > > > > > act > > > > > > > as a parent to 'XenDevice' PV backends. > > > > > > > A new 'XenBridge' object is also added to connect XenBus to > the > > > > system > > > > > > bus. > > > > > > > > > > > > > > The XenBus object is instantiated by a new xen_bus_init() > > function > > > > > > called > > > > > > > from the same sites as the legacy xen_be_init() function. > > > > > > > > > > > > > > Subsequent patches will flesh-out the functionality of these > > > > objects. > > > > > > > > > > > > > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > > > > > > > > > > > > > diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c > > > > > > > new file mode 100644 > > > > > > > index 0000000000..dede2d914a > > > > > > > --- /dev/null > > > > > > > +++ b/hw/xen/xen-bus.c > > > > > > > @@ -0,0 +1,125 @@ > > > > > > > +/* > > > > > > > + * Copyright (c) Citrix Systems Inc. > > > > > > > + * All rights reserved. > > > > > > > + */ > > > > > > > > > > > > This doesn't look very compatible with the GPL. In fact it might > > even > > > > > > make it illegal for the QEMU project to distribute this code. :- > ) > > > > > > > > > > > > Other files you add throughout the series seem to have the same > > > > problem. > > > > > > > > > > > > > > > > I was working on the assumption that a lack of explicit license > > meant > > > > that the overall project license as described in item 2 in LICENSE. > > Did I > > > > misinterpret that text? > > > > > > > > It's "All rights reserved." the problem > > > > > > Oh, I see. I'm happy to remove that. > > > > That would be better at least. I'm not sure about files that have a > > copyright header, but no license statement. Do such files exist yet in > > the source tree? > > Yes, there's quite a few... e.g. (first ones I tripped over) > hw/rdma/rdma_backend.c, hw/virtio/vhost-backend.c, ...
Oh... I see they have a license statement but no boilerplate... is that statement enough? Paul > > > To be on the safe side, I'd just stick with the > > established practice, which is having a license header in every file. > > Ok... if that is established practice. It really wasn't clear. > > > > > By the way, in a later patch you remove the existing license header, > > which is different from the default license (because parts of the source > > file are GPL 2 only). If you can't prove that all such parts (and parts > > derived from them) have been removed, this is also a problem. > > > > What should I do? I am duplicating xen_disk, and then heavily modifying > it. Should I just leave the old boilerplate in place? > > Paul > > > Kevin
