> -----Original Message----- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 11 December 2018 15:30 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: qemu-de...@nongnu.org; qemu-block@nongnu.org; xen- > de...@lists.xenproject.org; Kevin Wolf <kw...@redhat.com>; Stefano > Stabellini <sstabell...@kernel.org>; Stefan Hajnoczi > <stefa...@redhat.com>; Max Reitz <mre...@redhat.com> > Subject: Re: [Xen-devel] [PATCH v3 09/18] xen: remove unnecessary code > from dataplane/xen-block.c > > On Tue, Dec 11, 2018 at 10:47:09AM +0000, Paul Durrant wrote: > > v2: > > - Leave existing boilerplate alone, other than removing the now- > incorrect > > description > > --- > > hw/block/dataplane/xen-block.c | 409 ++-------------------------------- > ------- > > 1 file changed, 16 insertions(+), 393 deletions(-) > > > > diff --git a/hw/block/dataplane/xen-block.c b/hw/block/dataplane/xen- > block.c > > index 9fae505..98f987d 100644 > > --- a/hw/block/dataplane/xen-block.c > > +++ b/hw/block/dataplane/xen-block.c > > @@ -1,6 +1,4 @@ > > /* > > - * xen paravirt block device backend > > - * > > * (c) Gerd Hoffmann <kra...@redhat.com> > > * > > * This program is free software; you can redistribute it and/or > modify > > @@ -19,26 +17,12 @@ > > * GNU GPL, version 2 or (at your option) any later version. > > */ > > > > +/* > > + * Copyright (c) 2018 Citrix Systems Inc. > > Can you move this copyright line to the existing license boilerplate as > I've asked on v2? >
Oops. I thought I'd done this. > > + * > > + * This work is licensed under the terms of the GNU GPL, version 2 or > later. > > + * See the COPYING file in the top-level directory. > > And this isn't needed as it just duplicate the already existing one. > Sure. I'll send v4 with both these fixed. Paul > > + */ > > > > Thanks, > > -- > Anthony PERARD