Patchew URL: https://patchew.org/QEMU/20181211160224.22181-1-o...@aepfle.de/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181211160224.22181-1-o...@aepfle.de Subject: [Qemu-devel] [PATCH v1] xen_disk: fix memory leak Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' aaf3499 xen_disk: fix memory leak === OUTPUT BEGIN === Checking PATCH 1/1: xen_disk: fix memory leak... ERROR: braces {} are necessary for all arms of this statement #26: FILE: hw/block/xen_disk.c:108: + if (ioreq->buf) [...] ERROR: braces {} are necessary for all arms of this statement #32: FILE: hw/block/xen_disk.c:114: + if (ioreq->buf) [...] total: 2 errors, 0 warnings, 55 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20181211160224.22181-1-o...@aepfle.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com