15.12.2018 16:53, Eric Blake wrote: > Our copy-and-pasted open-coding of strtol handling forgot to > handle overflow conditions. Use qemu_strto*() instead. > > In the case of --partition, since we insist on a user-supplied > partition to be non-zero, we can use 0 rather than -1 for our > initial value to distinguish when a partition is not being > served, for slightly more optimal code. > > The error messages for out-of-bounds values are less specific, > but should not be a terrible loss in quality. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > > --- > v2: Retitle, catch more uses of strtol > [Hmm - this depends on int64_t and off_t being compatible; if they > aren't that way on all platforms, I'll need a temporary variable]
hmm, as I understand, even if this compatibility exists, it's not a part of standard and nothing about off_t size in POSIX.. Moreover: what is the reason for using off_t in NBD code? We don't have it in NBD protocol, we don't have it in generic block layer interface. Isn't it always casted to int64_t or like this? -- Best regards, Vladimir