Looks good to me.
Reviewed-by: Julio Faracco <jcfara...@gmail.com>
Em dom, 23 de dez de 2018 às 01:03, yuchenlin <npes87...@gmail.com>
escreveu:
> Signed-off-by: yuchenlin <npes87...@gmail.com>
> ---
> block/dmg.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/dmg.c b/block/dmg.c
> index 0e05702f5d..6b0a057bf8 100644
> --- a/block/dmg.c
> +++ b/block/dmg.c
> @@ -267,7 +267,7 @@ static int dmg_read_mish_block(BDRVDMGState *s,
> DmgHeaderState *ds,
>
> /* all-zeroes sector (type 2) does not need to be "uncompressed"
> and can
> * therefore be unbounded. */
> - if (s->types[i] != 2 && s->sectorcounts[i] >
> DMG_SECTORCOUNTS_MAX) {
> + if (s->types[i] != UDIG && s->sectorcounts[i] >
> DMG_SECTORCOUNTS_MAX) {
> error_report("sector count %" PRIu64 " for chunk %" PRIu32
> " is larger than max (%u)",
> s->sectorcounts[i], i, DMG_SECTORCOUNTS_MAX);
> @@ -706,7 +706,7 @@ dmg_co_preadv(BlockDriverState *bs, uint64_t offset,
> uint64_t bytes,
> /* Special case: current chunk is all zeroes. Do not perform a
> memcpy as
> * s->uncompressed_chunk may be too small to cover the large
> all-zeroes
> * section. dmg_read_chunk is called to find s->current_chunk */
> - if (s->types[s->current_chunk] == 2) { /* all zeroes block entry
> */
> + if (s->types[s->current_chunk] == UDIG) { /* all zeroes block
> entry */
> qemu_iovec_memset(qiov, i * 512, 0, 512);
> continue;
> }
> --
> 2.17.1
>
>
>
