Re: [Qemu-block] [PATCH v12 09/10] qcow2: skip writing zero buffers to empty COW areas

[Alberto Garcia]

On Wed 16 Jan 2019 10:32:33 AM CET, Anton Nefedov wrote:
>>> +        ret = handle_alloc_space(bs, l2meta);
>> 
>> I insist that it would be nice to have a short comment explaining
>> what this does.
>
> Right sorry forgot your comment.
> I'd go with:
>
> +        /* Try to efficiently initialize the physical space with zeroes */
>           ret = handle_alloc_space(bs, l2meta);
>           if (ret < 0) {
>               qemu_co_mutex_lock(&s->lock);

That looks good, thanks!

Berto