On Fri, Feb 15, 2019 at 09:38:59PM +0100, Philippe Mathieu-Daudé wrote: > On 2/15/19 5:25 PM, Paul Durrant wrote: > > The if() statement is clearly bogus (dead code which should have been > > cleaned up when grant mapping was removed). > > "... was removed in 06454c24ad)."
Actually, it looks like c6025bd197 should have remove the if statement. > > > > Spotted by Coverity: CID 1398635 > > > > While in the neighbourhood, add a missing 'fall through' annotation. > > > > Reported-by: Peter Maydell <peter.mayd...@linaro.org> > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> Thanks, -- Anthony PERARD