* Kevin Wolf (kw...@redhat.com) wrote:
> Am 05.04.2019 um 13:45 hat Markus Armbruster geschrieben:
> > drive_new() returns null without setting an error when it provided
> > help.  add_init_drive() assumes null means failure, and crashes trying
> > to report a null error.
> > 
> > Fixes: c4f26c9f37ce511e5fe629c21c180dc6eb7c5a25
> > Cc: qemu-sta...@nongnu.org
> > Signed-off-by: Markus Armbruster <arm...@redhat.com>
> 
> We should probably have a test case for this.

Perhaps just adding:

drive_add 0 format=help

to the hmp_cmds list in tests/test-hmp.c  ?

Dave

> Kevin
> 
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Reply via email to