> -----Original Message----- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 10 April 2019 16:52 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: qemu-de...@nongnu.org; xen-de...@lists.xenproject.org; > qemu-block@nongnu.org; Stefano Stabellini > <sstabell...@kernel.org>; Stefan Hajnoczi <stefa...@redhat.com>; Kevin Wolf > <kw...@redhat.com>; Max > Reitz <mre...@redhat.com> > Subject: Re: [PATCH] xen-block: support feature-large-sector-size > > On Tue, Apr 09, 2019 at 05:40:38PM +0100, Paul Durrant wrote: > > A recent Xen commit [1] clarified the semantics of sector based quantities > > used in the blkif protocol such that it is now safe to create a xen-block > > device with a logical_block_size != 512, as long as the device only > > connects to a frontend advertizing 'feature-large-block-size'. > > > > This patch modifies xen-block accordingly. It also uses a stack variable > > for the BlockBackend in xen_block_realize() to avoid repeated dereferencing > > of the BlockConf pointer, and changes the parameters of > > xen_block_dataplane_create() so that the BlockBackend pointer and sector > > size are passed expicitly rather than implicitly via the BlockConf. > > > > These modifications have been tested against a recent Windows PV XENVBD > > driver [2] using a xen-disk device with a 4kB logical block size. > > > > [1] > > http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=67e1c050e36b2c9900cca83618e56189effbad98 > > [2] https://winpvdrvbuild.xenproject.org:8080/job/XENVBD-master/126 > > > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > > --- > > diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c > > index ef635be4c2..05e890ad78 100644 > > --- a/hw/block/xen-block.c > > +++ b/hw/block/xen-block.c > > @@ -51,11 +51,25 @@ static void xen_block_connect(XenDevice *xendev, Error > > **errp) > [...] > > + if (xen_device_frontend_scanf(xendev, "feature-large-sector-size", > > "%u", > > + &feature_large_sector_size) != 1) { > > + feature_large_sector_size = 0; > > + } > > + > > + if (feature_large_sector_size != 1 && > > + conf->logical_block_size != XEN_BLKIF_SECTOR_SIZE) { > > + error_setg(errp, "logical_block_size != %u not supported", > > Maybe add "by frontend" to the error message?
Yes, I'm fine with that addition. > > > + XEN_BLKIF_SECTOR_SIZE); > > + return; > > + } > > + > > With the question answered: > Reviewed-by: Anthony PERARD <anthony.per...@citrix.com> > Thanks, Paul > Thanks, > > -- > Anthony PERARD
