Are you going to fix this when you apply the patch or should I?
> On 10 Apr 2019, at 23:07, Max Reitz <mre...@redhat.com> wrote:
>
> On 10.04.19 21:15, Max Reitz wrote:
>> On 26.03.19 20:58, Sam Eiderman wrote:
>>> Commit fb2105b ("vmdk: Support version=3 in VMDK descriptor files") fixed
>>> the probe function to correctly guess vmdk descriptors with version=3.
>>>
>>> This solves the issue where vmdk snapshot with parent vmdk descriptor
>>> containing "version=3" would be treated as raw instead vmdk.
>>>
>>> In the future case where a new vmdk version is introduced, we will again
>>> experience this issue, even if the user will provide "-f vmdk" it will
>>> only apply to the tip image and not to the underlying "misprobed" parent
>>> image.
>>>
>>> The code in vmdk.c already assumes that the backing file of vmdk must be
>>> vmdk (see vmdk_is_cid_valid which returns 0 if backing file is not
>>> vmdk).
>>>
>>> So let's make it official by supplying the backing_format as vmdk.
>>>
>>> Reviewed-by: Mark Kanda <mark.ka...@oracle.com>
>>> Reviewed-By: Liran Alon <liran.a...@oracle.com>
>>> Reviewed-by: Arbel Moshe <arbel.mo...@oracle.com>
>>> Signed-off-by: Shmuel Eiderman <shmuel.eider...@oracle.com>
>>> ---
>>> block/vmdk.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>
>> Because this is not in master yet, maybe it’s still time for me to say
>> that this breaks iotests 110 and 126 (requires a trivial fix to the
>> reference output).
>
> Correction: It’s a bit more complicated because both tests should work
> for other formats, too. So I guess the backing file format should be
> filtered from the output.
>
> Max
>
