On Sat 13 Apr 2019 02:56:57 AM CEST, Max Reitz wrote: >> Patch 2 fixes a different (but slightly related) issue that I found >> while preparing the first patch. > > I think the real problem is that bs->backing_file is not a cache for > bs->backing->bs->filename. > > In fact, every user of bs->backing_file expects it to be something > different. Some expect it to be a cache for > bs->backing->bs->filename, some expect it to be what the image header > says (i.e., it if’s a relative path, it’s relative to the overlay), > some expect it to be what the image header says, but relative paths to > be translated so they are relative to qemu’s CWD. > > All of this should be cleaned up and this is what patch 7 in my "block: > Deal with filters" series does: > > http://lists.nongnu.org/archive/html/qemu-block/2019-04/msg00308.html
Ok, you can leave out the second patch then. The first one should still be correct, right? Berto