On 16.05.19 16:43, Max Reitz wrote: > It is possible for an empty file to take up blocks on a filesystem, for > example: > > $ qemu-img create -f raw test.img 1G > Formatting 'test.img', fmt=raw size=1073741824 > $ mkfs.ext4 -I 128 -q test.img > $ mkdir test-mount > $ sudo mount -o loop test.img test-mount > $ sudo touch test-mount/test-file > $ stat -c 'blocks=%b' test-mount/test-file > blocks=8 > > These extra blocks (one cluster) are apparently used for metadata, > because they are always there, on top of blocks used for data: > > $ sudo dd if=/dev/zero of=test-mount/test-file bs=1M count=1 > 1+0 records in > 1+0 records out > 1048576 bytes (1.0 MB, 1.0 MiB) copied, 0.00135339 s, 775 MB/s > $ stat -c 'blocks=%b' test-mount/test-file > blocks=2056 > > Make iotest 175 take this into account. > > Reported-by: Thomas Huth <th...@redhat.com> > Signed-off-by: Max Reitz <mre...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: Nir Soffer <nsof...@redhat.com> > --- > v3: > - Actually tested this on an FS with the behavior in question and > noticed the patterns were lacking a $. Since I'm now sending a v3 > anyway, I might as well fix it with the heavy hammer and make it a > ($|[^0-9]). > - Added example configuration to the commit message [Nir] > - Kept the R-bs because I didn't feel too bad about doing so. > --- > tests/qemu-iotests/175 | 26 ++++++++++++++++++++++---- > tests/qemu-iotests/175.out | 8 ++++---- > 2 files changed, 26 insertions(+), 8 deletions(-)
Applied to my block branch. Max
signature.asc
Description: OpenPGP digital signature
