Patchew URL: https://patchew.org/QEMU/20190611134043.9524-1-kw...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 00/11] monitor: Split monitor.c in core/HMP/QMP/misc Type: series Message-id: 20190611134043.9524-1-kw...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20190611134043.9524-1-kw...@redhat.com -> patchew/20190611134043.9524-1-kw...@redhat.com Switched to a new branch 'test' 4db331c519 monitor: Split out monitor/monitor.c 899a21f035 monitor: Split out monitor/hmp.c 50416d4aeb monitor: Split out monitor/qmp.c 31d1fe8e42 monitor: Create monitor_int.h with common definitions 2c1ac4ecbf monitor: Move {hmp, qmp}.c to monitor/{hmp, qmp}-cmds.c 37f8c28eca Move monitor.c to monitor/misc.c 00674ed1c9 monitor: Move cmd_table to MonitorHMP 8a46bc8c85 monitor: Create MonitorHMP with readline state af6e2aad95 monitor: Make MonitorQMP a child class of Monitor c48181e5ab monitor: Split monitor_init in HMP and QMP function 82eb18147f monitor: Remove unused password prompting fields === OUTPUT BEGIN === 1/11 Checking commit 82eb18147fdf (monitor: Remove unused password prompting fields) 2/11 Checking commit c48181e5ab24 (monitor: Split monitor_init in HMP and QMP function) 3/11 Checking commit af6e2aad957c (monitor: Make MonitorQMP a child class of Monitor) 4/11 Checking commit 8a46bc8c859e (monitor: Create MonitorHMP with readline state) 5/11 Checking commit 00674ed1c9c7 (monitor: Move cmd_table to MonitorHMP) 6/11 Checking commit 37f8c28eca6f (Move monitor.c to monitor/misc.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 78 lines checked Patch 6/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/11 Checking commit 2c1ac4ecbfd5 (monitor: Move {hmp, qmp}.c to monitor/{hmp, qmp}-cmds.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #102: rename from hmp.c total: 0 errors, 1 warnings, 73 lines checked Patch 7/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/11 Checking commit 31d1fe8e4208 (monitor: Create monitor_int.h with common definitions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #171: new file mode 100644 total: 0 errors, 1 warnings, 290 lines checked Patch 8/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/11 Checking commit 50416d4aebc5 (monitor: Split out monitor/qmp.c) ERROR: return is not a function, parentheses are not required #585: FILE: monitor/monitor_int.h:154: + return (mon->flags & MONITOR_USE_CONTROL); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #609: new file mode 100644 total: 1 errors, 1 warnings, 966 lines checked Patch 9/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/11 Checking commit 899a21f0358e (monitor: Split out monitor/hmp.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 ERROR: consider using qemu_strtoull in preference to strtoull #409: FILE: monitor/hmp.c:364: + n = strtoull(pch, &p, 0); WARNING: Block comments use a leading /* on a separate line #1291: FILE: monitor/hmp.c:1246: + /* if the line ends with a space, it means we want to complete the WARNING: Block comments use a trailing */ on a separate line #1292: FILE: monitor/hmp.c:1247: + * next arg */ total: 1 errors, 3 warnings, 2878 lines checked Patch 10/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/11 Checking commit 4db331c5192d (monitor: Split out monitor/monitor.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #706: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #1313: FILE: monitor/monitor.c:603: + { /* end of list */ } total: 0 errors, 2 warnings, 1273 lines checked Patch 11/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190611134043.9524-1-kw...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com