Kevin Wolf <kw...@redhat.com> writes: > Create a new monitor/ subdirectory and move monitor.c there. As the plan > is to move the monitor core into separate files, use the chance to > rename it to misc.c.
I figure we'll want to move most of (all of?) monitor/misc.c out. Not a job this series must finish, of course. > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > docs/devel/writing-qmp-commands.txt | 2 +- > monitor.c => monitor/misc.c | 2 +- > MAINTAINERS | 4 ++-- > Makefile.objs | 1 + > Makefile.target | 3 ++- > monitor/Makefile.objs | 1 + > monitor/trace-events | 11 +++++++++++ > trace-events | 10 ---------- > 8 files changed, 19 insertions(+), 15 deletions(-) > rename monitor.c => monitor/misc.c (99%) > create mode 100644 monitor/Makefile.objs > create mode 100644 monitor/trace-events > > diff --git a/docs/devel/writing-qmp-commands.txt > b/docs/devel/writing-qmp-commands.txt > index 9dfc62bf5a..cc6ecd6d5d 100644 > --- a/docs/devel/writing-qmp-commands.txt > +++ b/docs/devel/writing-qmp-commands.txt > @@ -470,7 +470,7 @@ it's good practice to always check for errors. > > Another important detail is that HMP's "info" commands don't go into the > hmp-commands.hx. Instead, they go into the info_cmds[] table, which is > defined > -in the monitor.c file. The entry for the "info alarmclock" follows: > +in the monitor/misc.c file. The entry for the "info alarmclock" follows: Not this patch's fault, but this is wrong since commit da76ee76f78 (Sep 2015). Funny, the one place that provides advice on writing HMP commands is called writing-qmp-commands.txt %-} > > { > .name = "alarmclock", [...] Reviewed-by: Markus Armbruster <arm...@redhat.com>