13.06.2019 1:09, Max Reitz wrote: > The commit and mirror block nodes are filters, so they should be marked > as such. (Strictly speaking, BDS.is_filter's documentation states that > a filter's child must be bs->file. The following patch will relax this > restriction, however.) > > Signed-off-by: Max Reitz <mre...@redhat.com> > Reviewed-by: Alberto Garcia <be...@igalia.com> > Reviewed-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > --- > block/commit.c | 2 ++ > block/mirror.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/block/commit.c b/block/commit.c > index c815def89a..f20a26fecd 100644 > --- a/block/commit.c > +++ b/block/commit.c > @@ -256,6 +256,8 @@ static BlockDriver bdrv_commit_top = { > .bdrv_co_block_status = bdrv_co_block_status_from_backing, > .bdrv_refresh_filename = bdrv_commit_top_refresh_filename, > .bdrv_child_perm = bdrv_commit_top_child_perm, > + > + .is_filter = true, > }; > > void commit_start(const char *job_id, BlockDriverState *bs, > diff --git a/block/mirror.c b/block/mirror.c > index f8bdb5b21b..4fa8f57c80 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@ -1480,6 +1480,8 @@ static BlockDriver bdrv_mirror_top = { > .bdrv_co_block_status = bdrv_co_block_status_from_backing, > .bdrv_refresh_filename = bdrv_mirror_top_refresh_filename, > .bdrv_child_perm = bdrv_mirror_top_child_perm, > + > + .is_filter = true, > }; > > static void mirror_start_job(const char *job_id, BlockDriverState *bs, > -- Best regards, Vladimir