Patchew URL: https://patchew.org/QEMU/20190613153405.24769-1-kw...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190613153405.24769-1-kw...@redhat.com Subject: [Qemu-devel] [PATCH v3 00/15] monitor: Split monitor.c in core/HMP/QMP/misc Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 6d522fb vl: Deprecate -mon pretty=... for HMP monitors e34ac59 monitor: Replace monitor_init() with monitor_init_{hmp, qmp}() e75b96d monitor: Split Monitor.flags into separate bools 24a36f9 monitor: Split out monitor/monitor.c 27c4127 monitor: Split out monitor/hmp.c 26f727a monitor: Split out monitor/qmp.c b2685af monitor: Create monitor-internal.h with common definitions e1f6a6e monitor: Move {hmp, qmp}.c to monitor/{hmp, qmp}-cmds.c ea374f7 Move monitor.c to monitor/misc.c 21e390e monitor: Rename HMP command type and tables 3335bfc monitor: Remove Monitor.cmd_table indirection b935214 monitor: Create MonitorHMP with readline state 0800382 monitor: Make MonitorQMP a child class of Monitor 7c3f4f7 monitor: Split monitor_init in HMP and QMP function 6e68255 monitor: Remove unused password prompting fields === OUTPUT BEGIN === 1/15 Checking commit 6e68255df41e (monitor: Remove unused password prompting fields) 2/15 Checking commit 7c3f4f792c86 (monitor: Split monitor_init in HMP and QMP function) 3/15 Checking commit 080038232dc8 (monitor: Make MonitorQMP a child class of Monitor) 4/15 Checking commit b935214b2c2c (monitor: Create MonitorHMP with readline state) 5/15 Checking commit 3335bfc40060 (monitor: Remove Monitor.cmd_table indirection) 6/15 Checking commit 21e390e01266 (monitor: Rename HMP command type and tables) ERROR: spaces required around that '/' (ctx:VxV) #226: FILE: monitor.c:4543: + array_num = sizeof(hmp_cmds)/elem_size-1; ^ ERROR: spaces required around that '-' (ctx:VxV) #226: FILE: monitor.c:4543: + array_num = sizeof(hmp_cmds)/elem_size-1; ^ ERROR: spaces required around that '/' (ctx:VxV) #231: FILE: monitor.c:4546: + array_num = sizeof(hmp_info_cmds)/elem_size-1; ^ ERROR: spaces required around that '-' (ctx:VxV) #231: FILE: monitor.c:4546: + array_num = sizeof(hmp_info_cmds)/elem_size-1; ^ total: 4 errors, 0 warnings, 194 lines checked Patch 6/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/15 Checking commit ea374f7b2aad (Move monitor.c to monitor/misc.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #80: new file mode 100644 total: 0 errors, 1 warnings, 78 lines checked Patch 7/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/15 Checking commit e1f6a6ef1c06 (monitor: Move {hmp, qmp}.c to monitor/{hmp, qmp}-cmds.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #104: rename from hmp.c total: 0 errors, 1 warnings, 73 lines checked Patch 8/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/15 Checking commit b2685af3a437 (monitor: Create monitor-internal.h with common definitions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #175: new file mode 100644 total: 0 errors, 1 warnings, 290 lines checked Patch 9/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/15 Checking commit 26f727a38094 (monitor: Split out monitor/qmp.c) ERROR: return is not a function, parentheses are not required #564: FILE: monitor/monitor-internal.h:153: + return (mon->flags & MONITOR_USE_CONTROL); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #590: new file mode 100644 total: 1 errors, 1 warnings, 954 lines checked Patch 10/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/15 Checking commit 27c412749fec (monitor: Split out monitor/hmp.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 ERROR: consider using qemu_strtoull in preference to strtoull #432: FILE: monitor/hmp.c:400: + n = strtoull(pch, &p, 0); WARNING: Block comments use a leading /* on a separate line #1314: FILE: monitor/hmp.c:1282: + /* if the line ends with a space, it means we want to complete the WARNING: Block comments use a trailing */ on a separate line #1315: FILE: monitor/hmp.c:1283: + * next arg */ total: 1 errors, 3 warnings, 2919 lines checked Patch 11/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/15 Checking commit 24a36f947bcb (monitor: Split out monitor/monitor.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #725: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #1364: FILE: monitor/monitor.c:635: + { /* end of list */ } total: 0 errors, 2 warnings, 1316 lines checked Patch 12/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/15 Checking commit e75b96deb320 (monitor: Split Monitor.flags into separate bools) 14/15 Checking commit e34ac5963a50 (monitor: Replace monitor_init() with monitor_init_{hmp, qmp}()) 15/15 Checking commit 6d522fb23163 (vl: Deprecate -mon pretty=... for HMP monitors) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190613153405.24769-1-kw...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com