On 03.07.19 19:28, Max Reitz wrote: > This is a v2 to “block: Add BDS.never_freeze”. > > It depends on my “block: Delay poll when ending drained sections” > series: > > Depends-on: <20190619152603.5937-1-mre...@redhat.com> > > > It turned out that if you run 030 (or just the new test_overlapping_5 > case) sufficiently often, it breaks; which is why I’m hesitant to just > merge the “add never_freeze” series as it is. > > There are several reasons for why this test case breaks, I hope patches > 3 to 6 fix them. Patch 12 adds a test that is much more reliable than > test_overlapping_5 at detecting the problems fixed by at least patches 4 > to 6. (I think that 3 doesn’t really need a test.) > > I’m sure there are other ways to see these problems, but well, coming > from 030, concurrent commit/stream jobs are how I reproduced them. > Hence the same of this series. > > Patch 2 is for something I encountered on the way. Patch 11 tests it.
Applied patches 1, 2, 3, and 6 through 11 to my block branch. So what remains are patches 4, 5, and 12. For 4, I don’t know whether the approach is too heavy-handed (maybe a simple bdrv_drained_begin()/-end() would suffice), and whether it’s even right to wrap the whole function in a drained section. (Unless there are objections, I’ll still take it for rc2.) 5 is just pretty complex, and it also depends on my other series in its current form. So I wouldn’t like to take it without any reviews. 12 is a test that will fail without 4 and 5, so I can’t take it without those two. Max
signature.asc
Description: OpenPGP digital signature