On 10.08.19 15:32, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 19:13, Max Reitz wrote: >> In order to make filters work in backing chains, the associated >> functions must be able to deal with them and freeze all filter links, be >> they COW or R/W filter links. >> >> In the process, rename these functions to reflect that they now act on >> generalized chains of filter nodes instead of backing chains alone. >> >> While at it, add some comments that note which functions require their >> caller to ensure that a given child link is not frozen, and how the >> callers do so. >> >> Signed-off-by: Max Reitz <mre...@redhat.com> >> --- >> include/block/block.h | 10 +++--- >> block.c | 81 +++++++++++++++++++++++++------------------ >> block/commit.c | 8 ++--- >> block/mirror.c | 4 +-- >> block/stream.c | 8 ++--- >> 5 files changed, 62 insertions(+), 49 deletions(-)
[...] >> @@ -2477,10 +2481,6 @@ void bdrv_root_unref_child(BdrvChild *child) >> bdrv_unref(child_bs); >> } >> >> -/** >> - * Clear all inherits_from pointers from children and grandchildren of >> - * @root that point to @root, where necessary. >> - */ > > Hmm, unrelated chunk? Without it: > Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> I don’t know how that slipped in, sorry... Once again, thanks for reviewing! Max
signature.asc
Description: OpenPGP digital signature
