On 8/21/19 6:41 AM, Vladimir Sementsov-Ogievskiy wrote: > Should I resend with 07 dropped? >
At this point, the earlier patches in the series are now in-tree, and the later patches need rebasing again... >>> v7: >>> almost all: rebased on merged nbd.c and nbd-client.c (including patch >>> subject) >>> 01-04: add Eric's r-b >>> 04: wording >>> 05: new >>> 06: rewrite to remove timer earlier >>> 07: new >>> 08: >>> - rebase on 05 and 07 >>> - drop "All rights reserved" >>> - handle drain >>> - improve handling aio context attach >>> 09: move 249 -> 257 257 snuck into the tree for a different test, so you'll get to move it again. But yes, dropping patch 7 (with controversial SI unit addition) in favor of more discernable constants locally (such as NANOSECONDS_PER_SECOND) as part of the rebase is a good idea. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature