On Tue, Aug 20, 2019 at 08:29:55PM +0200, Max Reitz wrote: > On 14.08.19 22:22, Maxim Levitsky wrote: > > Signed-off-by: Maxim Levitsky <mlevi...@redhat.com> > > --- > > block/crypto.c | 16 ++++++ > > block/crypto.h | 3 + > > qemu-img-cmds.hx | 13 +++++ > > qemu-img.c | 140 +++++++++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 172 insertions(+) > > Yes, this seems a bit weird. Putting it under amend seems like the > natural thing if that works; if not, I think it should be a single > qemu-img subcommand instead of two.
I'm not convinced by overloading two distinct operations on to one sub-command - doesn't seem to give an obvious benefit to overload them & IME experiance overloading results in harder to understand commands due to having distinct args to each command. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
