Patchew URL: https://patchew.org/QEMU/20190918130244.24257-1-vsement...@virtuozzo.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC] error: auto propagated local_err Message-id: 20190918130244.24257-1-vsement...@virtuozzo.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 16e8874 error: auto propagated local_err === OUTPUT BEGIN === WARNING: line over 80 characters #291: FILE: include/qapi/error.h:391: +static inline void error_propagation_struct_cleanup(ErrorPropagationStruct *prop) ERROR: Macros with multiple statements should be enclosed in a do - while loop #301: FILE: include/qapi/error.h:401: +#define DEF_AUTO_ERRP_V2(auto_errp, errp) \ + g_auto(ErrorPropagationStruct) (__auto_errp_prop) = {.errp = (errp)}; \ + Error **auto_errp = \ + ((errp) == NULL || *(errp) == error_abort || *(errp) == error_fatal) ? \ + &__auto_errp_prop.local_err : \ + (errp); ERROR: Macros with multiple statements should be enclosed in a do - while loop #320: FILE: include/qapi/error.h:420: +#define MAKE_ERRP_SAFE(errp) \ +g_auto(ErrorPropagationStruct) (__auto_errp_prop) = {.errp = (errp)}; \ +if ((errp) == NULL || *(errp) == error_abort || *(errp) == error_fatal) { \ + (errp) = &__auto_errp_prop.local_err; \ +} total: 2 errors, 1 warnings, 277 lines checked Commit 16e8874947e7 (error: auto propagated local_err) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190918130244.24257-1-vsement...@virtuozzo.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com