On Mon, 2019-09-23 at 08:08 -0500, Eric Blake wrote: > On 9/12/19 5:30 PM, Maxim Levitsky wrote: > > This adds the qcrypto_amend_options and corresponding > > crypto driver callbacks for the for encrypted > > grammar is off, did you miss a word where that double space is? > > > key managedment > > management
Thank you! I'll try my best in the future to have less spelling and grammar errors like that. I need to double check every message prior to sending the patches. > > > > > Signed-off-by: Maxim Levitsky <mlevi...@redhat.com> > > Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> > > --- > > crypto/block.c | 31 +++++++++++++++++++++++++++++++ > > crypto/blockpriv.h | 8 ++++++++ > > include/crypto/block.h | 22 ++++++++++++++++++++++ > > 3 files changed, 61 insertions(+) > > > > diff --git a/crypto/block.c b/crypto/block.c > > index 325752871c..14b684de7f 100644 > > --- a/crypto/block.c > > +++ b/crypto/block.c > > @@ -115,6 +115,37 @@ QCryptoBlock > > *qcrypto_block_create(QCryptoBlockCreateOptions *options, > > } > > > > > > +int qcrypto_block_amend_options(QCryptoBlock *block, > > + QCryptoBlockReadFunc readfunc, > > + QCryptoBlockWriteFunc writefunc, > > + void *opaque, > > + QCryptoBlockCreateOptions *options, > > + bool force, > > + Error **errp) > > +{ > > + if (options->format != block->format) { > > + error_setg(errp, > > + "Its not possible to change encryption format with > > amend interface"); > > + return -1; > > "It's" (here, you want the form meaning "It is") > > Or reword the entire error to something shorter: > > error_setg(errp, "cannot amend encryption format") Same here. > Thanks for the review, Best regards, Maxim Levitsky