On 24/09/2019 20.49, John Snow wrote: > Nobody was making movement on this patch series, and in response to Max > acking the whole series, I was just going to send a pull request for the > whole thing and see who barked, because nobody likes or hates this > series enough to offer any feedback. > > Unfortunately, it's rotted on the vine a bit and has some conflicts with > the testing infrastructure now: > > /home/jhuston/src/qemu.git/ide/tests/hd-geo-test.c: In function > ‘test_override’: > /home/jhuston/src/qemu.git/ide/tests/hd-geo-test.c:732:5: error: > implicit declaration of function ‘qtest_start’ > [-Werror=implicit-function-declaration] > 732 | qtest_start(joined_args); > > > You can jump right to the test by invoking it like this: > >> export QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 >> make tests/hd-geo-test > > It looks like some definitions got moved out from under our feet, but > hopefully it won't take long to rectify.
Please replace qtest_start() with qts = qtest_init() and qtest_end() with qtest_quit(qts). See this commit for some more details: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=44c2364aaa5e366c4 Thomas
