Maxim Levitsky <mlevi...@redhat.com> writes:
> Signed-off-by: Maxim Levitsky <mlevi...@redhat.com>
> Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>
> ---
[...]
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 7900914506..4a6db98938 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -4211,8 +4211,11 @@
> # Driver specific image creation options for LUKS.
> #
> # @file Node to create the image format on
> +# Mandatory for create
> # @size Size of the virtual disk in bytes
> +# Mandatory for create
> # @preallocation Preallocation mode for the new image
> +# Only for create
> # (since: 4.2)
> # (default: off; allowed values: off, metadata, falloc,
> full)
> #
> @@ -4220,8 +4223,8 @@
> ##
> { 'struct': 'BlockdevCreateOptionsLUKS',
> 'base': 'QCryptoBlockCreateOptionsLUKS',
> - 'data': { 'file': 'BlockdevRef',
> - 'size': 'size',
> + 'data': { '*file': 'BlockdevRef',
> + '*size': 'size',
> '*preallocation': 'PreallocMode' } }
>
> ##
Why is this change needed?
When the commit message says "implement FOO" and nothing else, then I
don't expect QAPI schema changes. Working the answer to my question
into the commit message might avoid the surprise.
