Patchew URL: https://patchew.org/QEMU/20191015103900.313928-1-...@irrelevant.dk/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2 00/20] nvme: support NVMe v1.3d, SGLs and multiple namespaces Type: series Message-id: 20191015103900.313928-1-...@irrelevant.dk === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' c68f7e0 nvme: handle dma errors 855f2b8 nvme: make lba data size configurable 68fc575 nvme: remove redundant NvmeCmd pointer parameter eb585d1 nvme: bump controller pci device id 227280c nvme: support multiple namespaces ccc877b nvme: add support for scatter gather lists 76d6fe6 nvme: allow multiple aios per command 73227cb nvme: refactor prp mapping df5fd9f nvme: bump supported specification version to 1.3 c85c0ff nvme: add missing mandatory features 1188552 nvme: add logging to error information log page 714808c nvme: add support for the asynchronous event request command 88bdfce nvme: add support for the get log page command 7716649 nvme: refactor device realization 7d2d51e nvme: add support for the abort command 4ec0e81 nvme: allow completion queues in the cmb 68f00db nvme: populate the mandatory subnqn and ver fields f08d66a nvme: add missing fields in the identify controller data structure 315a6eb nvme: move device parameters to separate struct b94cf4a nvme: remove superfluous breaks === OUTPUT BEGIN === 1/20 Checking commit b94cf4aea07b (nvme: remove superfluous breaks) 2/20 Checking commit 315a6eb1f09f (nvme: move device parameters to separate struct) ERROR: Macros with complex values should be enclosed in parenthesis #177: FILE: hw/block/nvme.h:6: +#define DEFINE_NVME_PROPERTIES(_state, _props) \ + DEFINE_PROP_STRING("serial", _state, _props.serial), \ + DEFINE_PROP_UINT32("cmb_size_mb", _state, _props.cmb_size_mb, 0), \ + DEFINE_PROP_UINT32("num_queues", _state, _props.num_queues, 64) total: 1 errors, 0 warnings, 181 lines checked Patch 2/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/20 Checking commit f08d66aa761b (nvme: add missing fields in the identify controller data structure) 4/20 Checking commit 68f00db57e87 (nvme: populate the mandatory subnqn and ver fields) 5/20 Checking commit 4ec0e81a8ca5 (nvme: allow completion queues in the cmb) 6/20 Checking commit 7d2d51e5da89 (nvme: add support for the abort command) 7/20 Checking commit 7716649c3d6d (nvme: refactor device realization) 8/20 Checking commit 88bdfce1a599 (nvme: add support for the get log page command) 9/20 Checking commit 714808cd3ef8 (nvme: add support for the asynchronous event request command) 10/20 Checking commit 11885522fa87 (nvme: add logging to error information log page) 11/20 Checking commit c85c0ff5ea35 (nvme: add missing mandatory features) 12/20 Checking commit df5fd9f283a4 (nvme: bump supported specification version to 1.3) 13/20 Checking commit 73227cb3c83c (nvme: refactor prp mapping) 14/20 Checking commit 76d6fe6ea1cf (nvme: allow multiple aios per command) 15/20 Checking commit ccc877b6f72b (nvme: add support for scatter gather lists) 16/20 Checking commit 227280c8d08c (nvme: support multiple namespaces) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 total: 0 errors, 1 warnings, 801 lines checked Patch 16/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/20 Checking commit eb585d1231e3 (nvme: bump controller pci device id) 18/20 Checking commit 68fc575b3fc7 (nvme: remove redundant NvmeCmd pointer parameter) 19/20 Checking commit 855f2b86dd6c (nvme: make lba data size configurable) 20/20 Checking commit c68f7e0d0c55 (nvme: handle dma errors) WARNING: line over 80 characters #77: FILE: hw/block/nvme.c:257: + if (nvme_addr_read(n, prp_ent, (void *) prp_list, prp_trans)) { WARNING: line over 80 characters #103: FILE: hw/block/nvme.c:428: + if (nvme_addr_read(n, addr, segment, nsgld * sizeof(NvmeSglDescriptor))) { total: 0 errors, 2 warnings, 148 lines checked Patch 20/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20191015103900.313928-1-...@irrelevant.dk/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com