On 01.11.19 08:37, Tuguoyi wrote: > There are two issues in In check_constraints_on_bitmap(), > 1) The sanity check on the granularity will cause uint64_t > integer left-shift overflow when cluster_size is 2M and the > granularity is BIGGER than 32K. > 2) The way to calculate image size that the maximum bitmap > supported can map to is a bit incorrect. > This patch fix it by add a helper function to calculate the > number of bytes needed by a normal bitmap in image and compare > it to the maximum bitmap bytes supported by qemu. > > Fixes: 5f72826e7fc62167cf3a > Signed-off-by: Guoyi Tu <tu.gu...@h3c.com> > --- > block/qcow2-bitmap.c | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-)
Thanks, applied to my block branch: https://git.xanclic.moe/XanClic/qemu/commits/branch/block Max
signature.asc
Description: OpenPGP digital signature