On 22.11.19 17:41, Eric Blake wrote: > On 11/22/19 10:17 AM, Peter Maydell wrote:
[...] >> Eyeballing of the diffstat plus the fact we're on v4 of >> the patchset already makes me a little uneasy about >> putting it into rc3, but if the bug we're fixing matters >> enough we can do it. > > In terms of diffstat, the v3 series was much smaller in impact. Both > versions add robustness, where the difference between v3 and v4 is > whether we introduce a speed penalty on an unlikely setup (v3) or reject > any operation where it would require a speed penalty to avoid data > problems (v4). I’d just like to add that this isn’t just about a speed penalty, but about the fact that the monitor is blocked while the operation is running. So the speed penalty has more impact than just some background operation being slow. Max
signature.asc
Description: OpenPGP digital signature
