On Wed, Dec 18, 2019 at 9:20 PM Philippe Mathieu-Daudé <phi...@redhat.com> wrote: > > Hi, > > After this chat on #qemu IRC: > 13:20 <stsquad> so what is the difference between a IOReadHandler and > IOEventHandler? > 13:25 <f4bug> stsquad: one is in-band and the other out-of-band? > 13:26 <stsquad> f4bug: ahh yes it seems so - connect/disconnect etc... > 13:27 <f4bug> see QEMUChrEvent for IOEventHandler > > I thought it might be a good opportunity to make the IOEventHandler > typedef meaning more obvious, by using the QEMUChrEvent enum. > > To be able to build I had to explicit all enums ignored in the > switch(event) statement by these frontends. > > Then I used a coccinelle spatch to change the various IOEventHandler. > I don't think the last patch can be split, but suggestions are welcome! > > Regards, > > Phil. > > v2: > - do blindly ignore all events using a 'default' case. > > Philippe Mathieu-Daudé (14): > hw/ipmi: Remove unnecessary declarations > hw/ipmi: Explicit we ignore some QEMUChrEvent in IOEventHandler > hw/char/terminal3270: Explicit ignored QEMUChrEvent in IOEventHandler > hw/usb/dev-serial: Explicit we ignore few QEMUChrEvent in IOEventHandler > hw/usb/redirect: Explicit we ignore few QEMUChrEvent in IOEventHandler > ccid-card-passthru: Explicit we ignore QEMUChrEvent in IOEventHandler > vhost-user-crypto: Explicit we ignore some QEMUChrEvent in IOEventHandler > vhost-user-net: Explicit we ignore few QEMUChrEvent in IOEventHandler > vhost-user-blk: Explicit we ignore few QEMUChrEvent in IOEventHandler > virtio-console: Explicit we ignore some QEMUChrEvent in IOEventHandler > monitor/qmp: Explicit we ignore few QEMUChrEvent in IOEventHandler > monitor/hmp: Explicit we ignore a QEMUChrEvent in IOEventHandler > chardev/char: Explicit we ignore some QEMUChrEvent in IOEventHandler > chardev: Use QEMUChrEvent enum in IOEventHandler typedef
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> (I guess Paolo will take the series for next PR?) > > include/chardev/char-fe.h | 2 +- > include/chardev/char-mux.h | 2 +- > include/chardev/char.h | 4 ++-- > backends/cryptodev-vhost-user.c | 7 ++++++- > chardev/char-mux.c | 8 ++++---- > chardev/char.c | 9 +++++++-- > gdbstub.c | 2 +- > hw/arm/pxa2xx.c | 2 +- > hw/arm/strongarm.c | 2 +- > hw/block/vhost-user-blk.c | 7 ++++++- > hw/char/cadence_uart.c | 2 +- > hw/char/digic-uart.c | 2 +- > hw/char/escc.c | 2 +- > hw/char/etraxfs_ser.c | 2 +- > hw/char/exynos4210_uart.c | 2 +- > hw/char/grlib_apbuart.c | 2 +- > hw/char/imx_serial.c | 2 +- > hw/char/ipoctal232.c | 2 +- > hw/char/lm32_juart.c | 2 +- > hw/char/lm32_uart.c | 2 +- > hw/char/mcf_uart.c | 2 +- > hw/char/milkymist-uart.c | 2 +- > hw/char/nrf51_uart.c | 2 +- > hw/char/pl011.c | 2 +- > hw/char/serial.c | 2 +- > hw/char/sh_serial.c | 2 +- > hw/char/terminal3270.c | 7 ++++++- > hw/char/virtio-console.c | 7 ++++++- > hw/char/xilinx_uartlite.c | 2 +- > hw/ipmi/ipmi_bmc_extern.c | 12 +++++++----- > hw/mips/boston.c | 2 +- > hw/mips/mips_malta.c | 2 +- > hw/riscv/riscv_htif.c | 2 +- > hw/riscv/sifive_uart.c | 2 +- > hw/usb/ccid-card-passthru.c | 7 ++++++- > hw/usb/dev-serial.c | 6 +++++- > hw/usb/redirect.c | 7 ++++++- > monitor/hmp.c | 6 +++++- > monitor/qmp.c | 7 ++++++- > net/filter-mirror.c | 2 +- > net/vhost-user.c | 9 +++++++-- > qtest.c | 2 +- > tests/test-char.c | 6 +++--- > tests/vhost-user-test.c | 2 +- > 44 files changed, 111 insertions(+), 56 deletions(-) > > Cc: "Gonglei (Arei)" <arei.gong...@huawei.com> > Cc: "Marc-André Lureau" <marcandre.lur...@redhat.com> > Cc: Paolo Bonzini <pbonz...@redhat.com> > Cc: "Alex Bennée" <alex.ben...@linaro.org> > Cc: "Philippe Mathieu-Daudé" <phi...@redhat.com> > Cc: Andrzej Zaborowski <balr...@gmail.com> > Cc: Peter Maydell <peter.mayd...@linaro.org> > Cc: "Michael S. Tsirkin" <m...@redhat.com> > Cc: Kevin Wolf <kw...@redhat.com> > Cc: Max Reitz <mre...@redhat.com> > Cc: "Edgar E. Iglesias" <edgar.igles...@gmail.com> > Cc: Alistair Francis <alist...@alistair23.me> > Cc: Antony Pavlov <antonynpav...@gmail.com> > Cc: Igor Mitsyanko <i.mitsya...@gmail.com> > Cc: Fabien Chouteau <chout...@adacore.com> > Cc: KONRAD Frederic <frederic.kon...@adacore.com> > Cc: Peter Chubb <peter.ch...@nicta.com.au> > Cc: Alberto Garcia <be...@igalia.com> > Cc: Michael Walle <mich...@walle.cc> > Cc: Thomas Huth <h...@tuxfamily.org> > Cc: Joel Stanley <j...@jms.id.au> > Cc: Cornelia Huck <coh...@redhat.com> > Cc: Halil Pasic <pa...@linux.ibm.com> > Cc: Christian Borntraeger <borntrae...@de.ibm.com> > Cc: Laurent Vivier <lviv...@redhat.com> > Cc: Amit Shah <a...@kernel.org> > Cc: Corey Minyard <miny...@acm.org> > Cc: Paul Burton <pbur...@wavecomp.com> > Cc: Aleksandar Rikalo <aleksandar.rik...@rt-rk.com> > Cc: Aurelien Jarno <aurel...@aurel32.net> > Cc: Aleksandar Markovic <amarko...@wavecomp.com> > Cc: Palmer Dabbelt <pal...@dabbelt.com> > Cc: Sagar Karandikar <sag...@eecs.berkeley.edu> > Cc: Bastian Koppelmann <kbast...@mail.uni-paderborn.de> > Cc: Gerd Hoffmann <kra...@redhat.com> > Cc: Samuel Thibault <samuel.thiba...@ens-lyon.org> > Cc: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > Cc: Markus Armbruster <arm...@redhat.com> > Cc: Zhang Chen <chen.zh...@intel.com> > Cc: Li Zhijian <lizhij...@cn.fujitsu.com> > Cc: Jason Wang <jasow...@redhat.com> > Cc: qemu-...@nongnu.org > Cc: qemu-block@nongnu.org > Cc: qemu-s3...@nongnu.org > Cc: qemu-ri...@nongnu.org > > -- > 2.21.0 >
