On Thu 20 Feb 2020 05:48:25 PM CET, Eric Blake wrote: >>> The qcow2 spec changes earlier in the series made it sound like your >>> choices are exactly 1 or 32, >> >>>> +#define QCOW_MAX_SUBCLUSTERS_PER_CLUSTER 32 >>>> + >>> >>> ...but this name sounds like other values (2, 4, 8, 16) might be >>> possible? >> >> I guess I didn't want to call it QCOW_SUBCLUSTERS_PER_CLUSTER because >> there's already BDRVQcow2State.subclusters_per_cluster. And that one can >> have two possible values (1 and 32) so 32 would be the maximum. >> >> I get your point, however, and I'm open to suggestions. > > Maybe QCOW_EXTL2_SUBCLUSTERS_PER_CLUSTER > > since it is a hard-coded property of the EXTL2 feature.
Sounds good. Berto
