On Wed 04 Mar 2020 02:35:35 PM CET, Denis Plotnikov wrote: > +## > +# @Qcow2CompressionType:
I realized that we have a bit of a mix in the way we write this type of identifiers between QCow2FooBar (capital C) and Qcow2FooBar ... what's the recommended one? > @@ -146,6 +146,12 @@ typedef struct QCowHeader { > > uint32_t refcount_order; > uint32_t header_length; > + > + /* Additional fields */ > + uint8_t compression_type; > + > + /* header must be a multiple of 8 */ > + uint8_t padding[7]; > } QEMU_PACKED QCowHeader; Is it worth adding a static assertion here ? Berto