Re: [PATCH 1/3] Use &error_abort instead of separate assert()

[Vladimir Sementsov-Ogievskiy]

14.03.2020 7:58, Markus Armbruster wrote:

Alexander Bulekov <alx...@bu.edu> writes:

On 200313 1805, Markus Armbruster wrote:

Signed-off-by: Markus Armbruster <arm...@redhat.com>

index 1a99277d60..aa9eee6ebf 100644
--- a/tests/qtest/fuzz/qos_fuzz.c
+++ b/tests/qtest/fuzz/qos_fuzz.c
@@ -57,8 +57,7 @@ static void qos_set_machines_devices_available(void)
      QList *lst;
      Error *err = NULL;

Can this err declaration be removed? Don't think it's used anywhere
else.

Will do.

with this:

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>

-    qmp_marshal_query_machines(NULL, &response, &err);
-    assert(!err);
+    qmp_marshal_query_machines(NULL, &response, &error_abort);
      lst = qobject_to(QList, response);
      apply_to_qlist(lst, true);

@@ -70,8 +69,7 @@ static void qos_set_machines_devices_available(void)

      qdict_put_bool(args, "abstract", true);
      qdict_put_obj(req, "arguments", (QObject *) args);

- qmp_marshal_qom_list_types(args, &response, &err);

-    assert(!err);
+    qmp_marshal_qom_list_types(args, &response, &error_abort);
      lst = qobject_to(QList, response);
      apply_to_qlist(lst, false);
      qobject_unref(response);
--
2.21.1

Thanks!

Acked-by: Alexander Bulekov <alx...@bu.edu>

Thanks!

--
Best regards,
Vladimir