Re: [PATCH] block: Avoid memleak on qcow2 image info failure

[Vladimir Sementsov-Ogievskiy]

20.03.2020 21:36, Eric Blake wrote:

If we fail to get bitmap info, we must not leak the encryption info.

Fixes: b8968c875f403
Fixes: Coverity CID 1421894
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
  block/qcow2.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/block/qcow2.c b/block/qcow2.c
index d44b45633dbb..e08917ed8462 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -4811,6 +4811,7 @@ static ImageInfoSpecific 
*qcow2_get_specific_info(BlockDriverState *bs,
          if (local_err) {
              error_propagate(errp, local_err);
              qapi_free_ImageInfoSpecific(spec_info);
+            qapi_free_QCryptoBlockInfo(encrypt_info);
              return NULL;
          }
          *spec_info->u.qcow2.data = (ImageInfoSpecificQCow2){

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>

--
Best regards,
Vladimir