On Fri, 3 Apr 2020 10:04:57 +0200
Gerd Hoffmann <kra...@redhat.com> wrote:
> Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
> ---
[...]
> +static void rtc_build_aml(ISADevice *isadev, Aml *scope)
> +{
> + Aml *dev;
> + Aml *crs;
> +
> + crs = aml_resource_template();
> + aml_append(crs, aml_io(AML_DECODE16, 0x0070, 0x0070, 0x10, 0x02));
> + aml_append(crs, aml_irq_no_flags(8));
> + aml_append(crs, aml_io(AML_DECODE16, 0x0072, 0x0072, 0x02, 0x06));
since this is made a part of device, can we fetch io port values from
device instead of hard-codding values here?
> +
> + dev = aml_device("RTC");
> + aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0B00")));
> + aml_append(dev, aml_name_decl("_CRS", crs));
> +
> + aml_append(scope, dev);
> +}
> +
> static void rtc_class_initfn(ObjectClass *klass, void *data)
> {
> DeviceClass *dc = DEVICE_CLASS(klass);
> + ISADeviceClass *isa = ISA_DEVICE_CLASS(klass);
>
> dc->realize = rtc_realizefn;
> dc->reset = rtc_resetdev;
> dc->vmsd = &vmstate_rtc;
> + isa->build_aml = rtc_build_aml;
> device_class_set_props(dc, mc146818rtc_properties);
> }
>
