On Mar 31 12:10, Maxim Levitsky wrote: > On Tue, 2020-03-31 at 07:47 +0200, Klaus Birkelund Jensen wrote: > > On Mar 25 12:57, Maxim Levitsky wrote: > > > On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > > > > @@ -516,10 +613,10 @@ static inline uint16_t nvme_check_prinfo(NvmeCtrl > > > > *n, NvmeNamespace *ns, > > > > return NVME_SUCCESS; > > > > } > > > > > > > > -static inline uint16_t nvme_check_bounds(NvmeCtrl *n, NvmeNamespace > > > > *ns, > > > > - uint64_t slba, uint32_t nlb, > > > > - NvmeRequest *req) > > > > +static inline uint16_t nvme_check_bounds(NvmeCtrl *n, uint64_t slba, > > > > + uint32_t nlb, NvmeRequest > > > > *req) > > > > { > > > > + NvmeNamespace *ns = req->ns; > > > > uint64_t nsze = le64_to_cpu(ns->id_ns.nsze); > > > > > > This should go to the patch that added nvme_check_bounds as well > > > > > > > We can't really, because the NvmeRequest does not hold a reference to > > the namespace as a struct member at that point. This is also an issue > > with the nvme_check_prinfo function above. > > I see it now. The changes to NvmeRequest together with this are a good > candidate > to split from this patch to get this patch to size that is easy to review. >
I'm factoring those changes and other stuff out into separate patches!