On Wed 22 Apr 2020 02:06:56 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > 17.03.2020 21:16, Alberto Garcia wrote: >> Setting the QCOW_OFLAG_ZERO bit of the L2 entry is forbidden if an >> image has subclusters. Instead, the individual 'all zeroes' bits must >> be used. >> >> Signed-off-by: Alberto Garcia <be...@igalia.com> >> Reviewed-by: Max Reitz <mre...@redhat.com> > > Patch itself seems correct.. Still, would be good also to check, is > QCOW_OFLAG_ZERO set in subclustres case and add corresponding > corruptions++, and may be even fix (by using > QCOW_L2_BITMAP_ALL_ZEROES instead)
I'll add it to my TODO list for a later patch. Berto