On Tue, 5 May 2020 13:38:33 +0200 Gerd Hoffmann <kra...@redhat.com> wrote:
> Use a single io range for _CRS instead of two, > following what real hardware does. > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- > hw/rtc/mc146818rtc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c > index 2104e0aa3b14..47fafcfb7c1d 100644 > --- a/hw/rtc/mc146818rtc.c > +++ b/hw/rtc/mc146818rtc.c > @@ -1015,10 +1015,8 @@ static void rtc_build_aml(ISADevice *isadev, Aml > *scope) > > crs = aml_resource_template(); > aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE, > - 0x10, 0x02)); > + 0x10, 0x08)); > aml_append(crs, aml_irq_no_flags(RTC_ISA_IRQ)); > - aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE + 2, RTC_ISA_BASE + 2, > - 0x02, 0x06)); can we just drop the later range as unused? (I don't see where it's actually initialized) > > dev = aml_device("RTC"); > aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0B00")));