On Tue, May 19, 2020 at 06:11:34PM +0100, Stefan Hajnoczi wrote: > Do not access a CQE after incrementing q->cq.head and releasing q->lock. > It is unlikely that this causes problems in practice but it's a latent > bug. > > The reason why it should be safe at the moment is that completion > processing is not re-entrant and the CQ doorbell isn't written until the > end of nvme_process_completion(). > > Make this change now because QEMU expects completion processing to be > re-entrant and later patches will do that. > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > block/nvme.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Sergio Lopez <s...@redhat.com>
signature.asc
Description: PGP signature
