On Tue, Jun 09, 2020 at 03:59:44PM -0500, Eric Blake wrote: > The file qcow2.py was originally contributed in 2012 by Kevin Wolf, > but was not given traditional boilerplate headers at the time. The > missing license was just rectified (commit 16306a7b39) using the > project-default GPLv2+, but as Vladimir is not at Red Hat, he did not > add a Copyright line. All earlier contributions have come from CC'd > authors, where all but Stefan used a Red Hat address at the time of > the contribution, and that copyright carries over to the split to > qcow2_format.py (d5262c7124). > > CC: Kevin Wolf <kw...@redhat.com> > CC: Stefan Hajnoczi <stefa...@redhat.com> > CC: Eduardo Habkost <ehabk...@redhat.com> > CC: Max Reitz <mre...@redhat.com> > CC: Philippe Mathieu-Daudé <phi...@redhat.com> > CC: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Eric Blake <ebl...@redhat.com> > > --- > Commit ids above assume my bitmaps pull request does not have to be respun... > Based-on: <20200609205245.3548257-1-ebl...@redhat.com> > --- > tests/qemu-iotests/qcow2.py | 2 ++ > tests/qemu-iotests/qcow2_format.py | 1 + > 2 files changed, 3 insertions(+)
The git history shows which lines were contributed by IBM and is more detailed than a single copyright line at the top of the file. It's also common to make smaller contributions, like the one I made here, without adding a copyright line. In light of this I see no issue with adding a Red Hat copyright line and there is no need to add one for IBM: Acked-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature