On 6/11/20 9:29 AM, Gerd Hoffmann wrote:
> The _SB.PCI0.PX13.P13C opregion (holds isa device enable bits)
> is not used any more, remove it from DSDT.
Maybe:
"is not used any more (see previous commit), remove it from DSDT."
(if Michael can do the change when applying if you agree).
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
>
> Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
> Reviewed-by: Igor Mammedow <imamm...@redhat.com>
> ---
> hw/i386/acpi-build.c | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 750fcf9baa37..02cf4199c2e9 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1320,21 +1320,6 @@ static void build_q35_isa_bridge(Aml *table)
> aml_append(table, scope);
> }
>
> -static void build_piix4_pm(Aml *table)
> -{
> - Aml *dev;
> - Aml *scope;
> -
> - scope = aml_scope("_SB.PCI0");
> - dev = aml_device("PX13");
> - aml_append(dev, aml_name_decl("_ADR", aml_int(0x00010003)));
> -
> - aml_append(dev, aml_operation_region("P13C", AML_PCI_CONFIG,
> - aml_int(0x00), 0xff));
> - aml_append(scope, dev);
> - aml_append(table, scope);
> -}
> -
> static void build_piix4_isa_bridge(Aml *table)
> {
> Aml *dev;
> @@ -1486,7 +1471,6 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
> aml_append(dsdt, sb_scope);
>
> build_hpet_aml(dsdt);
> - build_piix4_pm(dsdt);
> build_piix4_isa_bridge(dsdt);
> build_isa_devices_aml(dsdt);
> build_piix4_pci_hotplug(dsdt);
>
