On Tue, Jun 30, 2020 at 10:02:15AM +0000, Niklas Cassel wrote: > On Mon, Jun 29, 2020 at 07:12:47PM -0700, Alistair Francis wrote: > > On Wed, Jun 17, 2020 at 2:47 PM Dmitry Fomichev <dmitry.fomic...@wdc.com> > > wrote: > > > + uint16_t ctrlid; > > > > Shouldn't this be CNTID? > > From the NVMe spec: > https://nvmexpress.org/wp-content/uploads/NVM-Express-1_4-2019.06.10-Ratified.pdf > > Figure 241: > Controller Identifier (CNTID) > > So you are correct, this is the official abbreviation. > > I guess that I tried wanted to keep it in sync with Linux: > https://github.com/torvalds/linux/blob/master/include/linux/nvme.h#L974 > > Which uses ctrlid. > > > Looking further at the NVMe spec: > In Figure 247 (Identify Controller Data Structure) they use other names > for fields: > > Controller ID (CNTLID) > Controller Attributes (CTRATT) > > I can understand if they want to have unique names for fields, but it > seems like they have trouble deciding how to abbreviate controller :) > > Personally I think that ctrlid is more obvious that we are talking about > a controller and not a count. But I'm fine regardless.
They shouldn't have shortened controller to "CNT". For those of us that can't help but pronounce these as words, that is a vulgarity in English.