Patchew URL: https://patchew.org/QEMU/20200702155000.3455325-1-arm...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2 00/44] Less clumsy error checking Type: series Message-id: 20200702155000.3455325-1-arm...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 581316d hmp: Ignore Error objects where the return value suffices 382f9cc qdev: Ignore Error objects where the return value suffices 2d54031 qemu-img: Ignore Error objects where the return value suffices c1da551 error: Avoid error_propagate() after migrate_add_blocker() 584033a qapi: Purge error_propagate() from QAPI core d5c18e7 qapi: Smooth visitor error checking in generated code a0b2eb7 qapi: Smooth another visitor error checking pattern 59fbe03 error: Reduce unnecessary error propagation d5401ed error: Eliminate error_propagate() manually 28da452 error: Eliminate error_propagate() with Coccinelle, part 2 249518d error: Eliminate error_propagate() with Coccinelle, part 1 79d26b3 error: Avoid unnecessary error_propagate() after error_setg() 69f21ee qdev: Use returned bool to check for failure, Coccinelle part cc10b4f qdev: Make functions taking Error ** return bool, not void 937e007 qom: Make functions taking Error ** return bool, not 0/-1 c13008d qom: Use returned bool to check for failure, manual part a76e6b8a qom: Use returned bool to check for failure, Coccinelle part 5831b19 qom: Make functions taking Error ** return bool, not void ee89136 qom: Put name parameter before value / visitor parameter cca92e7 qom: Use return values to check for error where that's simpler b3e4fbd qom: Don't handle impossible object_property_get_link() failure 64c3868 qom: Crash more nicely on object_property_get_link() failure 1045bbb qom: Rename qdev_get_type() to object_get_type() a90aa52 qom: Use error_reportf_err() instead of g_printerr() in examples 042c119 s390x/pci: Fix harmless mistake in zpci's property fid's setter 7556520 block/parallels: Simplify parallels_open() after previous commit 67c3627 qapi: Use returned bool to check for failure, manual part d461f88 qapi: Use returned bool to check for failure, Coccinelle part 61c3c84 qapi: Make visitor functions taking Error ** return bool, not void e11841d hmp: Eliminate a variable in hmp_migrate_set_parameter() b11147d block: Avoid error accumulation in bdrv_img_create() 5ddfdab qemu-option: Use returned bool to check for failure 132ed75 qemu-option: Make functions taking Error ** return bool, not void 48a09ea qemu-option: Replace opt_set() by cleaner opt_validate() 7ea945d qemu-option: Factor out helper opt_create() 378230d qemu-option: Simplify around find_default_by_name() 419b8e9 qemu-option: Factor out helper find_default_by_name() 066fe51 qemu-option: Make uses of find_desc_by_name() more similar 5ce56fe qemu-option: Check return value instead of @err where convenient 367ec25 virtio-crypto-pci: Tidy up virtio_crypto_pci_realize() 8df3b8f macio: Tidy up error handling in macio_newworld_realize() 0e00e46 qdev: Use returned bool to check for qdev_realize() etc. failure 15a41a5 error: Document Error API usage rules 6cc06a1 error: Improve examples in error.h's big comment === OUTPUT BEGIN === 1/44 Checking commit 6cc06a1b48e4 (error: Improve examples in error.h's big comment) ERROR: Error messages should not contain newlines #37: FILE: include/qapi/error.h:27: + * error_setg(errp, "invalid quark\n" // WRONG! total: 1 errors, 0 warnings, 42 lines checked Patch 1/44 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/44 Checking commit 15a41a5ba273 (error: Document Error API usage rules) 3/44 Checking commit 0e00e463e690 (qdev: Use returned bool to check for qdev_realize() etc. failure) 4/44 Checking commit 8df3b8f872d3 (macio: Tidy up error handling in macio_newworld_realize()) 5/44 Checking commit 367ec250efbc (virtio-crypto-pci: Tidy up virtio_crypto_pci_realize()) 6/44 Checking commit 5ce56fec2a32 (qemu-option: Check return value instead of @err where convenient) 7/44 Checking commit 066fe5182eff (qemu-option: Make uses of find_desc_by_name() more similar) 8/44 Checking commit 419b8e946ee0 (qemu-option: Factor out helper find_default_by_name()) 9/44 Checking commit 378230df0dc2 (qemu-option: Simplify around find_default_by_name()) 10/44 Checking commit 7ea945df03f9 (qemu-option: Factor out helper opt_create()) 11/44 Checking commit 48a09ea2ba72 (qemu-option: Replace opt_set() by cleaner opt_validate()) 12/44 Checking commit 132ed750d145 (qemu-option: Make functions taking Error ** return bool, not void) 13/44 Checking commit 5ddfdab3ea45 (qemu-option: Use returned bool to check for failure) 14/44 Checking commit b11147d3bdb9 (block: Avoid error accumulation in bdrv_img_create()) 15/44 Checking commit e11841d3030d (hmp: Eliminate a variable in hmp_migrate_set_parameter()) 16/44 Checking commit 61c3c848b6f0 (qapi: Make visitor functions taking Error ** return bool, not void) WARNING: line over 80 characters #2444: FILE: scripts/qapi/visit.py:26: +bool visit_type_%(c_name)s(Visitor *v, const char *name, %(c_type)sobj, Error **errp); WARNING: line over 80 characters #2512: FILE: scripts/qapi/visit.py:124: +bool visit_type_%(c_name)s(Visitor *v, const char *name, %(c_name)s **obj, Error **errp) WARNING: line over 80 characters #2541: FILE: scripts/qapi/visit.py:160: +bool visit_type_%(c_name)s(Visitor *v, const char *name, %(c_name)s *obj, Error **errp) WARNING: line over 80 characters #2556: FILE: scripts/qapi/visit.py:174: +bool visit_type_%(c_name)s(Visitor *v, const char *name, %(c_name)s **obj, Error **errp) WARNING: line over 80 characters #2585: FILE: scripts/qapi/visit.py:251: +bool visit_type_%(c_name)s(Visitor *v, const char *name, %(c_name)s **obj, Error **errp) total: 0 errors, 5 warnings, 2403 lines checked Patch 16/44 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/44 Checking commit d461f8867781 (qapi: Use returned bool to check for failure, Coccinelle part) 18/44 Checking commit 67c362706f2c (qapi: Use returned bool to check for failure, manual part) WARNING: Block comments use a leading /* on a separate line #75: FILE: accel/kvm/kvm-all.c:3154: + /* The value was checked in visit_type_OnOffSplit() above. If total: 0 errors, 1 warnings, 187 lines checked Patch 18/44 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/44 Checking commit 75565203b812 (block/parallels: Simplify parallels_open() after previous commit) 20/44 Checking commit 042c119aa19e (s390x/pci: Fix harmless mistake in zpci's property fid's setter) 21/44 Checking commit a90aa524a204 (qom: Use error_reportf_err() instead of g_printerr() in examples) 22/44 Checking commit 1045bbbb2d70 (qom: Rename qdev_get_type() to object_get_type()) 23/44 Checking commit 64c3868a955b (qom: Crash more nicely on object_property_get_link() failure) 24/44 Checking commit b3e4fbdfec68 (qom: Don't handle impossible object_property_get_link() failure) 25/44 Checking commit cca92e793452 (qom: Use return values to check for error where that's simpler) 26/44 Checking commit ee891363b634 (qom: Put name parameter before value / visitor parameter) 27/44 Checking commit 5831b192b1dd (qom: Make functions taking Error ** return bool, not void) 28/44 Checking commit a76e6b8a15e6 (qom: Use returned bool to check for failure, Coccinelle part) 29/44 Checking commit c13008d7bb4c (qom: Use returned bool to check for failure, manual part) 30/44 Checking commit 937e00767b62 (qom: Make functions taking Error ** return bool, not 0/-1) 31/44 Checking commit cc10b4f41f1a (qdev: Make functions taking Error ** return bool, not void) 32/44 Checking commit 69f21ee97c11 (qdev: Use returned bool to check for failure, Coccinelle part) 33/44 Checking commit 79d26b3ac25a (error: Avoid unnecessary error_propagate() after error_setg()) 34/44 Checking commit 249518ddad5c (error: Eliminate error_propagate() with Coccinelle, part 1) 35/44 Checking commit 28da452ec5a2 (error: Eliminate error_propagate() with Coccinelle, part 2) 36/44 Checking commit d5401ede69e8 (error: Eliminate error_propagate() manually) 37/44 Checking commit 59fbe0365f51 (error: Reduce unnecessary error propagation) 38/44 Checking commit a0b2eb7cd24c (qapi: Smooth another visitor error checking pattern) 39/44 Checking commit d5c18e763db3 (qapi: Smooth visitor error checking in generated code) 40/44 Checking commit 584033a37ab4 (qapi: Purge error_propagate() from QAPI core) 41/44 Checking commit c1da55153c47 (error: Avoid error_propagate() after migrate_add_blocker()) 42/44 Checking commit 2d5403100bb7 (qemu-img: Ignore Error objects where the return value suffices) 43/44 Checking commit 382f9cc1af9d (qdev: Ignore Error objects where the return value suffices) 44/44 Checking commit 581316d1a224 (hmp: Ignore Error objects where the return value suffices) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200702155000.3455325-1-arm...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com