Re: [PATCH v9 31/34] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit

[Alberto Garcia]

On Thu 02 Jul 2020 05:13:02 PM CEST, Max Reitz wrote:
>> +        } else if (!strcmp(desc->name, BLOCK_OPT_EXTL2)) {
>> +            bool extended_l2 = qemu_opt_get_bool(opts, BLOCK_OPT_EXTL2,
>> +                                                 has_subclusters(s));
>> +            if (extended_l2 != has_subclusters(s)) {
>> +                error_setg(errp, "Toggling extended L2 entries "
>> +                           "is not supported");
>> +                return -EINVAL;
>
> Just a note: I think ENOTSUP would fit better.
>
> (Then again, Maxim’s “block/amend: refactor qcow2 amend options”
> removes all of this code anyway.)

I can still change that :)

Berto