On 7/17/20 3:14 AM, Andrey Shinkevich wrote:
Add dirty bitmap information to QCOW2 metadata dump in the qcow2_format.py.
v10:
01: Fixing of issues in QCOW2 extension classes noted by Vladimir.
02: Reading bitmap tables was moved into Qcow2BitmapTable class.
03: Handling '-j' key was moved into "if __name__" section.
04: Making copy of __dict__ was replaced with the method to_dict().
05: Qcow2HeaderExtensionsDoc is introduced in the separate patch.
Andrey Shinkevich (11):
qcow2: Fix capitalization of header extension constant.
qcow2_format.py: make printable data an extension class member
qcow2_format.py: change Qcow2BitmapExt initialization method
qcow2_format.py: dump bitmap flags in human readable way.
qcow2_format.py: Dump bitmap directory information
qcow2_format.py: pass cluster size to substructures
qcow2_format.py: Dump bitmap table serialized entries
qcow2.py: Introduce '-j' key to dump in JSON format
qcow2_format.py: collect fields to dump in JSON format
qcow2_format.py: introduce Qcow2HeaderExtensionsDoc class
qcow2_format.py: support dumping metadata in JSON format
block/qcow2.c | 2 +-
docs/interop/qcow2.txt | 2 +-
tests/qemu-iotests/qcow2.py | 18 ++-
tests/qemu-iotests/qcow2_format.py | 221 ++++++++++++++++++++++++++++++++++---
4 files changed, 220 insertions(+), 23 deletions(-)
I still don't see any obvious coverage of the new output, which makes it
harder to test (I have to manually run qcow2.py on a file rather than
seeing what changes in a ???.out file). I know we said back in v9 that
test 291 is not the right test, but that does not stop you from adding a
new test just for that purpose.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org