On Thu, Aug 20, 2020 at 06:58:51PM +0200, Philippe Mathieu-Daudé wrote: > Do not use the same error message for different failures. > Display a different error whether it is the CQ or the SQ. > > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > block/nvme.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Stefano Garzarella <sgarz...@redhat.com> > > diff --git a/block/nvme.c b/block/nvme.c > index 003809fbd83..53448b7d230 100644 > --- a/block/nvme.c > +++ b/block/nvme.c > @@ -648,7 +648,7 @@ static bool nvme_add_io_queue(BlockDriverState *bs, Error > **errp) > .cdw11 = cpu_to_le32(0x3), > }; > if (nvme_cmd_sync(bs, s->queues[INDEX_ADMIN], &cmd)) { > - error_setg(errp, "Failed to create io queue [%d]", n); > + error_setg(errp, "Failed to create CQ io queue [%d]", n); > nvme_free_queue_pair(q); > return false; > } > @@ -659,7 +659,7 @@ static bool nvme_add_io_queue(BlockDriverState *bs, Error > **errp) > .cdw11 = cpu_to_le32(0x1 | (n << 16)), > }; > if (nvme_cmd_sync(bs, s->queues[INDEX_ADMIN], &cmd)) { > - error_setg(errp, "Failed to create io queue [%d]", n); > + error_setg(errp, "Failed to create SQ io queue [%d]", n); > nvme_free_queue_pair(q); > return false; > } > -- > 2.26.2 > >