On Thu, 2020-07-16 at 14:33 +0300, Maxim Levitsky wrote: > This is basically the same thing as commit > 'crypto.c: cleanup created file when block_crypto_co_create_opts_luks fails' > does but for qcow2 files to ensure that we don't leave qcow2 files > when creation fails. > > Signed-off-by: Maxim Levitsky <mlevi...@redhat.com>
Very kind ping on this patch. Best regards, Maxim levitsky > --- > block/qcow2.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/block/qcow2.c b/block/qcow2.c > index fadf3422f8..8b848924b5 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -3794,6 +3794,17 @@ static int coroutine_fn > qcow2_co_create_opts(BlockDriver *drv, > /* Create the qcow2 image (format layer) */ > ret = qcow2_co_create(create_options, errp); > if (ret < 0) { > + > + Error *local_delete_err = NULL; > + int r_del = bdrv_co_delete_file(bs, &local_delete_err); > + /* > + * ENOTSUP will happen if the block driver doesn't support > + * the 'bdrv_co_delete_file' interface. This is a predictable > + * scenario and shouldn't be reported back to the user. > + */ > + if ((r_del < 0) && (r_del != -ENOTSUP)) { > + error_report_err(local_delete_err); > + } > goto finish; > } >