> -----Original Message----- > From: Klaus Jensen <i...@irrelevant.dk> > Sent: Tuesday, September 15, 2020 3:37 AM > To: Dmitry Fomichev <dmitry.fomic...@wdc.com> > Cc: Keith Busch <kbu...@kernel.org>; Klaus Jensen > <k.jen...@samsung.com>; Kevin Wolf <kw...@redhat.com>; Philippe > Mathieu-Daudé <phi...@redhat.com>; Maxim Levitsky > <mlevi...@redhat.com>; Fam Zheng <f...@euphon.net>; Niklas Cassel > <niklas.cas...@wdc.com>; Damien Le Moal <damien.lem...@wdc.com>; > qemu-block@nongnu.org; qemu-de...@nongnu.org; Alistair Francis > <alistair.fran...@wdc.com>; Matias Bjorling <matias.bjorl...@wdc.com> > Subject: Re: [PATCH v3 01/15] hw/block/nvme: Define 64 bit cqe.result > > On Sep 14 07:14, Dmitry Fomichev wrote: > > From: Ajay Joshi <ajay.jo...@wdc.com> > > > > A new write command, Zone Append, is added as a part of Zoned > > Namespace Command Set. Upon successful completion of this command, > > the controller returns the start LBA of the performed write operation > > in cqe.result field. Therefore, the maximum size of this variable > > needs to be changed from 32 to 64 bit, consuming the reserved 32 bit > > field that follows the result in CQE struct. Since the existing > > commands are expected to return a 32 bit LE value, two separate > > variables, result32 and result64, are now kept in a union. > > > > Signed-off-by: Ajay Joshi <ajay.jo...@wdc.com> > > Signed-off-by: Dmitry Fomichev <dmitry.fomic...@wdc.com> > > Reviewed-by: Klaus Jensen <k.jen...@samsung.com> > > I know that I R-b'ed this, but can this be moved to the namespace types > patch, since that is the TP that changes this.
You probably meant the ZNS patch since result64 is first used there to return ZA starting data LBA. Sure, I can move this stuff to that patch. > > Also, I don't think we should touch the tracing in the block driver > since it is not aware of namespace types. Ok
