Patchew URL: https://patchew.org/QEMU/20200921162949.553863-1-phi...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200921162949.553863-1-phi...@redhat.com Subject: [PATCH 0/6] block/nvme: Map doorbells pages write-only, remove magic from nvme_init === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' b0ef8b7 block/nvme: Replace magic value by SCALE_MS definition 1792c4d block/nvme: Use register definitions from 'block/nvme.h' 352be0c block/nvme: Drop NVMeRegs structure, directly use NvmeBar 7aa184a block/nvme: Reduce I/O registers scope 4b1effc block/nvme: Map doorbells pages write-only 7ae4653 util/vfio-helpers: Pass page protections to qemu_vfio_pci_map_bar() === OUTPUT BEGIN === 1/6 Checking commit 7ae46536369a (util/vfio-helpers: Pass page protections to qemu_vfio_pci_map_bar()) 2/6 Checking commit 4b1effcfcd2b (block/nvme: Map doorbells pages write-only) 3/6 Checking commit 7aa184a756dc (block/nvme: Reduce I/O registers scope) 4/6 Checking commit 352be0c97869 (block/nvme: Drop NVMeRegs structure, directly use NvmeBar) ERROR: Use of volatile is usually wrong, please add a comment #43: FILE: block/nvme.c:692: + volatile NvmeBar *regs; total: 1 errors, 0 warnings, 62 lines checked Patch 4/6 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/6 Checking commit 1792c4da4bc2 (block/nvme: Use register definitions from 'block/nvme.h') 6/6 Checking commit b0ef8b776eb1 (block/nvme: Replace magic value by SCALE_MS definition) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200921162949.553863-1-phi...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com